Skip to content

Implement #c:foods/dough#2912

Merged
TelepathicGrunt merged 2 commits intoneoforged:1.21.xfrom
IThundxr:tags/dough
Jan 17, 2026
Merged

Implement #c:foods/dough#2912
TelepathicGrunt merged 2 commits intoneoforged:1.21.xfrom
IThundxr:tags/dough

Conversation

@IThundxr
Copy link
Copy Markdown
Contributor

@IThundxr IThundxr commented Jan 8, 2026

Implement #c:foods/dough, should contain any dough related item, more specific types can go under #c:foods/dough/<type> for example: #c:foods/dough/rye

Fabric PR: FabricMC/fabric-api#5125

@neoforged-automation neoforged-automation Bot added the 1.21.11 Targeted at Minecraft 1.21.11 label Jan 8, 2026
@neoforged-pr-publishing
Copy link
Copy Markdown

  • Publish PR to GitHub Packages

@KnightMiner
Copy link
Copy Markdown
Contributor

KnightMiner commented Jan 9, 2026

I mentioned this on the Neo Discord, but just to make sure its addressed here, I am of the opinion all new tags need javadocs explaining them. I've been burned too many times trying to use a common tag without javadocs when other modders make different assumptions.

At minimum, the PR description has some info that belongs in the javadoc (about the example subtags). But I'd also want to answer the following question:

Can I assume that anything under say, c:foods/dough/wheat would be capable of smelting into 1 vanilla bread? This basically breaks down into two parts:

  • Is all dough in c:foods/dough value of 1 bread (vanilla or modded equivelent), or can it be variable? I think its more useful if its the same value and I don't know of any mods using another size. e.g. Farmers Delight has dumpling recipes that don't care the dough type.
  • Is all dough in this tag expected to be bakeable as is, or can "incomplete" doughs be tagged? Again, I think its more useful if we include the assumption of bakeable, but that should be in the javadoc.

May also be worth saying these tags should not be used in furnace recipes, mods should add dough to bread recipes for their specific items. Above questions are for usages outside furnaces.

@TelepathicGrunt TelepathicGrunt merged commit 417531c into neoforged:1.21.x Jan 17, 2026
6 checks passed
@neoforged-releases
Copy link
Copy Markdown

🚀 This PR has been released as NeoForge version 21.11.34-beta.

@TelepathicGrunt TelepathicGrunt added the backport to 1.21.1 Add this label to a PR to backport it to 1.21.1 label Jan 17, 2026
neoforged-automation Bot pushed a commit that referenced this pull request Jan 17, 2026
@neoforged-automation
Copy link
Copy Markdown
Contributor

Created backport PR: #2928

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

1.21.11 Targeted at Minecraft 1.21.11

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants